Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to change audio attribute from alarm to notification #2743

Conversation

dibyendusaha
Copy link
Contributor

for commit #2676 : it is better to have audio attribute as USAGE_NOTIFICATION instead of USAGE_ALARM, as it will give control to device notification volume instead of alarm.
Please find my comment and related finding here

…USAGE_NOTIFICATION instead of USAGE_ALARM, as it will give control to device notification volume instead of alarm
@carlpoole
Copy link
Member

Thanks for your contribution. Agreed, this should be on the appropriate sound channel.

@imhoffd imhoffd merged commit b2d50f9 into ionic-team:master Jul 7, 2020
@dibyendusaha
Copy link
Contributor Author

Thanks for your contribution. Agreed, this should be on the appropriate sound channel.

Thanks for accepting the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants